Review: Approve

Looks good, but when merging I suggest we also:

 - change the search() in _next_by_* to use order="company_id" to give higher 
priority to company-specific
   sequences when no sequence is found for preferred company (this will work 
because NULLs are sorted
   last in PostgreSQL)
 - add something in the docstrings to mention that force_company can be passed
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-863221-nch/+merge/82124
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/trunk-bug-863221-nch.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to