Review: Needs Fixing
Hi Ujjvala,
i've got the confirmation from Aline that it was ok from a functional point of
view. But in terms of implementation, there are several things i'd like you to
improve before merging this branch.
1) there is one big problem in this code: the multi company rules are totally
bypassed as you're making psql queries directly to get the information. This
ain't good. You have to replace your queries by ordinary function calls (read,
browse, search...). Please: compute everything you need in one row (among the
same function).
2) line 337:
+ 'user_ids': fields.many2many('res.users', 'sale_user_rel_details', 'user_id',
'uid', 'Salesman'),
=> not clean: the name of the new relation is not appropriate. Use
pos_details_report_user_rel
=> not clean: the column names are not appropriate. Use wizard_id, user_id
=> typo: Salesmen instead of Salesman
Thanks,
Quentin
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-pos_sales_details_report-uco/+merge/75123
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-pos_sales_details_report-uco.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
