Review: Needs Fixing

I think it'd make more sense for this code to be in the `complete` or `success` 
section of the rpc call, in order to close the dialog (if there is one) only 
after the report has successfully been fetched. Because currently, the user is 
going to see his dialog disappear (behind the blockUI) as he's waiting for the 
report, and if there's an error while generating the report the user will lose 
any custom data entered into the dialog.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-891342-ysa/+merge/82644
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-891342-ysa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to