Review: Approve Looks good to me, I will remove the use of CONCURRENCY_CHECK_FIELD as well when merging, it's useless indeed.
For your last comment, yes the filter is correct, we want to keep only fields that can be directly aggregated by the database, i.e. the local fields (not inherited) that are stored (_classic_write==True). Thanks! -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-read-group-aggregated-fields-selection-improvements-xmo/+merge/82272 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-read-group-aggregated-fields-selection-improvements-xmo. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
