There are following improvements needed in different files:

* test/ui/execute_config.yml
  -> File seems incomplete.

* test/process/order_policy.yml
  -> 1st line is too long, doesn't look good when we run it on server.
  -> 3rd line, grammatical mistake, it should be "For testing.." instead of 
"For test.." and 4th line, "After confirmed Quotation1, I check that related 
Packing created and it's linked with order." not good. Grammer is wrong. It 
should be "After Quotation1 is confirmed,... related Picking is created and it 
is linked.." the same changes are needed on following lines too.
  -> For policy names it would be good if we write 'Pay before delivery' 
instead of 'Prepaid' and so on.
  -> There are some unwanted import statements:
     from datetime import datetime, timedelta
     from dateutil.relativedelta import relativedelta
     from tools import DEFAULT_SERVER_DATE_FORMAT, 
DEFAULT_SERVER_DATETIME_FORMAT
  -> Replace "Packing" with "Picking" from all lines.
  -> Line# "Now, create draft invoice on based of picking for order1 ..." with 
"Now, I create... for Quotation1.." same change for following lines.

* test/process/run_scheduler.yml
  -> "...I will take a Quotation which some products..." replace with "... with 
some products .."

* test/process/cancel_order.yml
  -> "For cancel the sale order..." it should be "To cancel the sale order..."
  -> "Now need to cancel the rekated picking..." it should be "Now I need to 
cancel the related picking..."

* test/process/get_picking_details.yml
  -> I don't get it, what does this file for.

* test/ui/sale_make_invoice.yml
  -> Open-ERP incorrect, its OpenERP.
  -> assert inv, "Invoices.." replace with "Invoice.." or "Invoices are not 
created".

* test/ui/make_advance_invoice.yml
  -> Here too add the corrections from above file.
  -> Instead of "I create a record for pay..." it should be "I create a record 
to pay..."
  -> Full stops are missing.

* test/ui/delete_order.yml
  -> I think we can ommit try..except for draft and cancelled orders.
  -> For cancelled order, context value is not given but passed in the argument.

* test/ui/sale_report.yml
  -> "...we will print a sale order" better written as "...I print Quotation 
report".

* test/edi_sale_order.yml should be mentioned in __openerp__.py

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-coverage-sales-dbr/+merge/82394
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-coverage-sales-dbr.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to