Review: Needs Fixing * The background image set for the delete button of list views does not exist (there is no "iconset-b-remove.gif" in the client, did you forget to add it to your working copy?) => the button does not appear anymore (also use PNG files if possible, they tend to be smaller than GIF ones and gives us the flexibility of partial transparency and truecolor if needed)
* Some lines are mis-indented (with tabs instead of spaces :() * Also line 766 in base.css could probably use a minimal `background` property instead of manually setting 4 sub-properties of background :) Likewise line 807 * Danger danger (high voltage) at e.g. line 799 a `display: inline` was removed. It's generally here for older IE versions which don't handle `inline-block` and whose `inline` behaves the same way. I don't know which IE versions we're supposed to support and the state of this in IE8, but it might not be a good idea to remove it. * I don't think there's much point to numerical font weight, I'd rather we used the normal (words) kind. * Line 1207, is there a reason for adding commented properties? Is it stuff that does not work just yet? And I find the form and search labels a bit too small, they're uncomfortable to read. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-font-size-ahu/+merge/83152 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-font-size-ahu. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
