Review: Needs Fixing
Hello,
Proposed Changes for merging seems ok except one assertion every-time
(mention at end) and also missed few function Assertion listed below:
> marketing.campaign
Missing function Assertion :
- state_done_set
- state_cancel_set
- signal
- copy
> marketing.campaign.segment
- onchange_campaign_id Never Triggered
- state_done_set
- state_cancel_set
The yaml added by you are good on bases of the Demo we have, but in case of
campaign activity with email will brak the whole flow of the yaml as email
template added via demo are not complete. Instead
We need to create new small campaign and Segmentation with filter under
yaml for testing can not use existing demo as it contain the email action and
can not be triggered on demo,
Instead Proposed solution can be
- Create A Campaign With Normal Mode on crm.lead (check - run, cancel,
reset, close) in YAML.
- 1) Create "Initial Activity" with Action Report in it.
- 2) Create "Initial Stage Activity End" Deny with Dummy Server action on
it.
- 3) Create "Second Offer Activity Followed By Initial Offer Stage With
Report Activity.
- 4) Create "End Campaign Activity" With Dummy Activity.
- Create Segment with "ir.filter" (can be added using demo) applied of
crm.lead type=lead and statw=new in YAML
- than Run the Segment on the Campaign which test (Run, Cancel, Reset,
Run, Close)
And Current Improvement Gives following Trace back which needed to be Imp :
-----------------------------------
[2011-11-24 05:36:07,536][test] TEST:tests.marketing_campaign_crm_demo:I
process the event of belgium partner which is particiapated with our campaing
activity, after processing the event, automatic email send to that partner with
specific message and check the status of event.
[2011-11-24 05:36:07,546][test]
ERROR:tests.marketing_campaign_crm_demo:AssertionError in Python code :
Activity items not created
[2011-11-24 05:36:07,546][test] ERROR:tests.marketing_campaign_crm_demo:Severe
assertion failure (ERROR), aborting.
Traceback (most recent call last):
File "/home/jam/rdtools/server/trunk/openerp/tools/yaml_import.py", line 844,
in process
self._process_node(node)
File "/home/jam/rdtools/server/trunk/openerp/tools/yaml_import.py", line 859,
in _process_node
self.process_python(node)
File "/home/jam/rdtools/server/trunk/openerp/tools/yaml_import.py", line 532,
in process_python
self._log_assert_failure(python.severity, 'AssertionError in Python code
%s: %s', python.name, e)
File "/home/jam/rdtools/server/trunk/openerp/tools/yaml_import.py", line 224,
in _log_assert_failure
raise YamlImportAbortion('Severe assertion failure (%s), aborting.' %
levelname)
YamlImportAbortion: Severe assertion failure (ERROR), aborting.
[2011-11-24 05:36:07,548][test] ERROR:init.test:Tests failed to execute in
module marketing_campaign_crm_demo
Thank You
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-coverage-marketing-ron/+merge/82637
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-coverage-marketing-ron.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
