> I'm setting this merge prop to WIP because I don't think it's fit for > inclusion in trunk yet (or at all) > ok I'm agree with you to go this module in OpenERP Apps
> Some examples: > > - remaining print statements and some code commented out Done. corrected it and use logger instead of print > - launchpad login cannot be something you have to set in the code, this would > need to be configurable somewhere ok. I will set launchpad login and path of cach direcotory into ir.proporty. > - no proper module description Done. > - strange multi-step definition for constants like MERGE_STATUS. Is this due > to a bad copy/past from the community-dashboard implementation script? ;-) I taken idea from community-dashboard implementation script. I removed multi-step for MERGE_STATUS . No need now after put constants for MERGE_STATUS_FILTERS. > PS: according to our merge proposal acceptance policy[1] this will probably be > going to OpenERP Apps via extra-addons rather than trunk. > > [1] http://bit.ly/openerp-contrib-mp Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-project_merge_proposal-hmo/+merge/83274 Your team OpenERP R&D Team is requested to review the proposed merge of lp:~openerp-dev/openobject-addons/trunk-project_merge_proposal-hmo into lp:openobject-addons. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
