Review: Needs Fixing

Hello Hemendra,

*remove old yml file.
*Introductory statement missing..add it.
*I set Daily tasks into Weekly Timebox=> you are just setting one task here so 
make it singular and add the name of the task.
*I check Weekly Timebox of task after set Timebox=>I check task set to weekly 
timebox
*last statement=> make it 'Next' instead of 'Previous' as you are checking 
next_timebox().
*line 29&30: here you are suppose to check whether timebox_id.id == 
ref("timebox_weekly") .
*line 45to55: prev_timebox() and next_timebox() methods check if the returned 
value is a valid action.
*for line32 to 43:-
-line 40: you have emptied the daily timebox but you are checking the task 
'Develop time management module' which has never been in 'Daily timebox'
-line 42: the id you are using here is not of 'Develop time management 
module'....!!
Correct this block.

Thanks,
Meera
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-polish2-improvement_yml_project_gtd-hpa/+merge/82881
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-polish2-improvement_yml_project_gtd-hpa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to