Review: Approve
Looks good to me, we indeed need a way to turn of the binary sanitize for local
usage only, as this mechanism is only present to protect remote RPC call. And
the latin1-encoding is really only needed when we receive a unicode string
directly from the database (via psycopg2), as we need a byte string to process.
One small detail: when you update a dict with literal keys, you can pass them
as keyword args to avoid creating a useless temporary dict. E.g.:
context.update(bin_raw=True) ... or the classical context['bin_raw'] = True.
Even if surrounding code doesn't do it ;-)
And kudos for not passing a default value to context.get('bin_raw') when we
don't need one! :-)
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-891544-nch/+merge/83570
Your team OpenERP R&D Team is requested to review the proposed merge of
lp:~openerp-dev/openobject-server/trunk-bug-891544-nch into
lp:openobject-server.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
