Review: Needs Fixing * I can see mixes of tabs and spaces in indent * I'm not too sure about the handling of the actionmanager buttons, especially as it's very easy to create new views (indeed we're currently splitting the form view into two different views) - as a result, I don't think removing the label of the button is a good idea, or at the very list the view buttons sprite should provide some sort of default for "unknown" view types. - also views-icons-a.png seems to be missing * And the kanban, graph, gantt, calendar, … styling should be in their respective addons (and CSS), not in the web's - as per this item, the view switcher probably shouldn't use a sprite, but a separate image per button. This way each addon could provide the images it needs for its views. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-button-ahu/+merge/83912 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-button-ahu.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
