Review: Approve Looks good to me, my only *very minor* concerns are:
- accepting a context in res.partner.display_address() is not strictly necessary as we currently read everything via the received browse_record, but it could be good to allow it just in case, for future use. - as the method on res.partner cannot be used via RPC (it takes a browse_record param), we should perhaps make it private (_display_address) - a tooltip explaining the available patterns for address_format would be great - not sure there's a good reason to define the sample address_formats as evaluated strings instead of literal XML values, which would make them slightly more readable, but that would disrupt the indentation level, so I guess we can live with it.. Thanks! -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-per_country_address_format/+merge/84113 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-per_country_address_format. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
