Review: Needs Fixing
Hello Devishree,
I have checked your merge proposal and found following improvements and
corrections:
General Improvements:
==============
* Put "Cold storage" and "Refrigerated vehicles" locations in demo file and
remove from data file.
* In all files replace 'picking' with 'Incoming shipment'/'Internal
move'/'Delivery order' respectively.
Improvements for specific file:
==================
* stock_demo_picking.yml :
-> No need to add sentences.
-> For records add only those fields which are necessary but doesn't get
filled up by 'on change' of any other field.
* test/stock_physical_inventory.yml :
-> In order to ... I start it from physical inventory.
should be replaced with: In order to ... I need to create initial physical
inventory.
-> I create a record for physical inventory...
should be replaced with: I create a physical inventory.
-> Combine both sentences like:
I define and fill the inventory. Create record using create method.
Also do not assign the 'context' value directly use another variable say
ctx={} and update with context.
-> Moves are created after you confirm inventory so need an assert after
confirmation.
-> Moves are from Inventory Loss to location given in inventory line. Should
be an assert.
-> Need to improve assert statements.
Instead of 'After confirm the ...' directly write "Inventory should be in
'Confirmed' state"
and likewise..
* test/stock_update.yml :
-> I think this file is not needed.
-> When I run the tests second time with -u stock option on server I got the
following error on test/stock_update.yml
I check that physical inventory created.
[2011-12-05 11:27:08,430][stock5] ERROR:tests.stock:AssertionError in
Python code : product Quantity is not correspond
[2011-12-05 11:27:08,430][stock5] ERROR:tests.stock:Severe assertion
failure (ERROR), aborting.
Traceback (most recent call last):
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 844, in process
self._process_node(node)
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 859, in _process_node
self.process_python(node)
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 532, in process_python
self._log_assert_failure(python.severity, 'AssertionError in Python
code %s: %s', python.name, e)
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 224, in _log_assert_failure
raise YamlImportAbortion('Severe assertion failure (%s), aborting.' %
levelname)
YamlImportAbortion: Severe assertion failure (ERROR), aborting.
* test/stock_chain_location.yml :
-> "In order to test the chain location...."
be replaced with: "In order to test chained locations, I update the stock
of product."
-> Production lot is not needed.
-> 'Sprouting Foods' is not a proper product.
-> "I update product 'Sprouting Foods' with the help of...."
should be replaced with: "I update product quantity and check the stock
moves are properly done or not."
And following steps can be combined in single step.
* test/stock_demo_backorder.yml :
-> "In order to test partial delivery and back orders,...."
should be replaced with: "In order to test partial delivery and back
orders, I select delivery order and check process on it."
-> "I confirm the delivery order 'OUT001'..."
should be replaced with: "I confirm the delivery order."
-> "After confirmed the picking...."
should be replaced with: "I add a new move line in the delivery order."
-> "I click on 'Process Now' to process..."
should be replaced with: "I make partial delivery for the delivery order."
-> "I test that the back order ... "
should be replaced with: "I check the backorder and its moves."
You can combine last two tests here.
* test/stock_scrap_move.yml :
-> "In order to test the scrap move, I add create ...."
should be replaced with: "In order to test the scrap move, I create moves
and scrap some quantities from those moves."
-> Following step can be:
=> I create a move and scrap some quantities from it.
* test/stock_new_pack.yml :
-> Got an error for the following sentence (with new db):
I split the picking in to two quantities.
[2011-12-05 05:46:06,066][stock5] ERROR:tests.stock:AssertionError in
Python code : After spliting the picking, new move should be created with new
pack
[2011-12-05 05:46:06,066][stock5] ERROR:tests.stock:Severe assertion
failure (ERROR), aborting.
Traceback (most recent call last):
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 844, in process
self._process_node(node)
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 859, in _process_node
self.process_python(node)
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 532, in process_python
self._log_assert_failure(python.severity, 'AssertionError in Python
code %s: %s', python.name, e)
File
"/home/uco/workspace/branches/rdtools/server/trunk/openerp/tools/yaml_import.py",
line 224, in _log_assert_failure
raise YamlImportAbortion('Severe assertion failure (%s), aborting.' %
levelname)
YamlImportAbortion: Severe assertion failure (ERROR), aborting.
-> Other files did not get loaded due to this error.
Thanks,
Ujjvala
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-coverage-stock-dbr/+merge/83918
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-coverage-stock-dbr.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
