Review: Needs Fixing

Hello Hemendra,

hr_timesheet_sheet:-
-I assign this product and journal to employee "Quentin Paolino"=>dont 
use'this',write name of product and journal
-use assert wherever you are calling the methods

project_timesheet:-
-you don't need to create hr.analytic.timesheet record,instead check whether 
timesheet lines entry is created on task work entry
-improve statements
-better move the yml file instead of adding

Thanks,
Meera
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-clean_yml_project_timesheet-hpa/+merge/84449
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-clean_yml_project_timesheet-hpa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to