Review: Needs Fixing Please keep the attribute noupdate="1" in the XML of demo data.
I noticed that the coverage of hr_expense/hr_expense.py went from 78% to 68% :-( The following functions/methods in hr_expense.py are not covered: - _employee_get, - hr_expense_expense.copy, - hr_expense_expense.onchange_employee_id, - product_product.on_change_hr_expense_ok, - hr_expense_line.onchange_product_id. Removing the "view: False" in hr_expense/test/expense_demo.yml may help here. Just add some assert in the file to check the effect of the onchange methods. Try to get all the functions/methods above covered. Otherwise, it's good! Thanks, Raphael -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-clean_yml_hr_expense-jap/+merge/83114 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-clean_yml_hr_expense-jap. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
