Review: Disapprove

This solution is unacceptable, totally non-modular!  You will not code every 
other use of survey inside module survey, will you?

The methods 'write' and 'survey_req_done' of model 'hr.evaluation.interview' 
should be called at lines 574-575 in survey/survey.py.  Please check first 
whether those work for model 'survey.request'.  Then, make sure it works for 
model 'hr.evaluation.interview'.  But do not put special code for 
'hr.evaluation.interview' inside module survey.

Thanks,
Raphael

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-891037-bde/+merge/83158
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-891037-bde.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to