Review: Needs Fixing
Hello Atik,
After checking your merge proposal I found the following things to be improved:
* line no: 18,19, Revert changes.
* line no: 31, Sentence case: "I refuse.." instead of "I Refuse.."
* line no: 45,101, No need to update context there.
* line no: 108, "I Not give Employeement to Hired Aplicant till." wrong
grammer. It should be "I do not give employment to the hired the applicant."
- Correct the spelling of "employment" in the following sentence too.
* line no: 117-125 can be combined in one python block like following:
!python {model: hr.applicant}: |
hired_emp_obj = self.pool.get('hired.employee')
self.case_reset(cr, uid, [ref("hr_case_programmer")])
self.case_open(cr, uid, [ref("hr_case_programmer")])
context.update({'active_model': 'hr.applicant', 'active_ids':
[ref("hr_recruitment.hr_case_programmer")], 'active_id':
ref("hr_recruitment.hr_case_programmer")})
emp_hr_id = hired_emp_obj.create(cr, uid, {}, context=context)
hired_emp_obj.case_close_with_emp(cr, uid, [emp_hr_id], context=context)
Thanks,
Ujjvala
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-hr-recruitment-yml-aag/+merge/85317
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-hr-recruitment-yml-aag.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
