Review: Needs Fixing

Why is test/all_schedular.yml commented in procurement/__openerp__.py?
If class StockPicking should be removed, then remove it.

Please try to keep the yaml !python sections as simple as possible.  Ideally, 
you should only use them for browsing records and asserting conditions.

Some of your python code even looks nonsensical to me.  For instance, this:

  !python {model: procurement.orderpoint.compute}: |
    proc_id = context.get('proc')
    context.update({'active_model':'procurement.order','active_id':proc_id})
    values = self.default_get(cr, uid, ['automatic'], context)
    values.update({'automatic':True})
    ids = self.create(cr, uid, values, context)

does nothing more than:

  !record {model: procurement.orderpoint.compute, id: choose_an_id_here}:
    automatic: True

Thanks,
Raphael

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-coverage-procurement-dbr/+merge/85823
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-coverage-procurement-dbr.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to