Fix has been merged into trunk. I made a few modifications to your fix. I would
like to highlight the following points :
- when using a "try - except" statement, you should specify the error type
(OSError in this case). Otherwise you will catch *all* exceptions, which is not
recommended.
- when importing a module, a good practice is to perform the import at file
beginning.
- concerning logging, use of netsvc is deprecated. You should instead use the
python logging module. For example, instead of writing :
-- logger = netsvc.Logger()
-- logger.notifyChannel(...)
you should write something like :
-- logger : logging.getLogger('module.name')
-- logger.log(...) in which you specify the log level; or directly methods like
logger.warn(...) or logger.error(...)
Best regards,
Thibault.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-905279-sgo/+merge/86204
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-905279-sgo.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
