Review: Needs Fixing
I don't see the point of the changes in hr_evaluation/hr_evaluation.py. First,
your method survey_req_draft_answer is identical to survey_req_draft. Second,
the state of the survey request is 'draft' by default. So calling that method
is useless.
Besides that, your change in survey/wizard/survey_answer.py is unacceptable to
me. It will break with everything except 'hr.evaluation.interview'. Why don't
you use 'active_model' to determine the model of the survey request? Wouldn't
this do the job, and work with any extension of 'survey.request'?
survey_req_obj = self.pool.get(context.get('active_model'))
if survey_req_obj and hasattr(survey_req_obj, 'survey_req_done'):
survey_req_obj.survey_req_done(cr, uid, context.get('active_ids', []),
context=context)
Please fix this.
(Don't forget to put the MP back to 'Needs Review' once done.)
Thanks,
Raphael
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-hr_periodic_evaluation-han/+merge/87331
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-hr_periodic_evaluation-han.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
