Review: Needs Fixing

The tests in document_ftp do not run properly when you install the module from 
the command line: it cannot find the service 'db'.  We should figure out why, 
because otherwise document_ftp cannot be tested on the runbot.

Now I did install the module from the GUI (web).  There is an error in the 
server logs for the file test/document_ftp_test4.yml.  See the following 
extract:

[2012-01-11 10:11:02,310][foo] INFO:init.load:module document_ftp: loading 
test/document_ftp_test4.yml
[2012-01-11 10:11:02,353][foo] INFO:FTP:[]127.0.0.1:39527 Connected.
[2012-01-11 10:11:02,354][foo] INFO:FTP:[]@127.0.0.1:39527 Disconnected.
[2012-01-11 10:11:02,835][foo] INFO:FTP:[]127.0.0.1:39528 Connected.
[2012-01-11 10:11:02,840][foo] INFO:FTP:[admin]@127.0.0.1:39528 User admin 
logged in.
[2012-01-11 10:11:02,868][foo] INFO:FTP:[admin]@127.0.0.1:39528 OK CWD "/foo/".
[2012-01-11 10:11:02,884][foo] INFO:FTP:[admin]@127.0.0.1:39528 OK CWD 
"/foo/Documents/Partners Testing".
[2012-01-11 10:11:02,900][foo] INFO:FTP:[admin]@127.0.0.1:39528 OK NLST "". 
Transfer starting.
[2012-01-11 10:11:02,942][foo] INFO:FTP:[admin]@127.0.0.1:39528 Disconnected.
[2012-01-11 10:11:03,069][foo] INFO:FTP:[]127.0.0.1:39530 Connected.
[2012-01-11 10:11:03,073][foo] INFO:FTP:[admin]@127.0.0.1:39530 User admin 
logged in.
[2012-01-11 10:11:03,101][foo] INFO:FTP:[admin]@127.0.0.1:39530 OK CWD "/foo/".
[2012-01-11 10:11:03,117][foo] INFO:FTP:[admin]@127.0.0.1:39530 OK CWD 
"/foo/Documents/Partners Testing".
[2012-01-11 10:11:03,152][foo] INFO:FTP:[admin]@127.0.0.1:39530 OK NLST "All 
Partner1+2/Partners of Test". Transfer starting.
[2012-01-11 10:11:03,224][foo] INFO:FTP:[admin]@127.0.0.1:39530 OK NLST "Pat 
1/Partners of Test". Transfer starting.
[2012-01-11 10:11:03,288][foo] INFO:FTP:[admin]@127.0.0.1:39530 OK NLST "No 
partners/Partners of Test". Transfer starting.
[2012-01-11 10:11:03,330][foo] INFO:FTP:[admin]@127.0.0.1:39530 Disconnected.
[2012-01-11 10:11:03,469][foo] INFO:FTP:[]127.0.0.1:39534 Connected.
[2012-01-11 10:11:03,473][foo] INFO:FTP:[admin]@127.0.0.1:39534 User admin 
logged in.
[2012-01-11 10:11:03,501][foo] INFO:FTP:[admin]@127.0.0.1:39534 OK CWD "/foo/".
[2012-01-11 10:11:03,517][foo] INFO:FTP:[admin]@127.0.0.1:39534 OK CWD 
"/foo/Documents/Partners Testing".
[2012-01-11 10:11:03,566][foo] INFO:FTP:[admin]@127.0.0.1:39534 OK NLST "All 
Partner1+2/Partners of Test/Partner 1". Transfer starting.
[2012-01-11 10:11:03,649][foo] INFO:FTP:[admin]@127.0.0.1:39534 OK NLST "Pat 
1/Partners of Test/Partner 1". Transfer starting.
[2012-01-11 10:11:03,689][foo] INFO:FTP:[admin]@127.0.0.1:39534 Disconnected.
[2012-01-11 10:11:03,690][foo] INFO:FTP:[]127.0.0.1:39537 Connected.
[2012-01-11 10:11:03,694][foo] INFO:FTP:[admin]@127.0.0.1:39537 User admin 
logged in.
[2012-01-11 10:11:03,718][foo] INFO:FTP:[admin]@127.0.0.1:39537 OK CWD "/foo/".
[2012-01-11 10:11:03,765][foo] INFO:FTP:[admin]@127.0.0.1:39537 OK CWD 
"/foo/Documents/Partners Testing/Pat 1/Partners of Test/Partner 1".
[2012-01-11 10:11:03,809][foo] INFO:FTP:[admin]@127.0.0.1:39537 OK STOR 
"pat1-dynamic.txt". Upload starting.
[2012-01-11 10:11:03,811][foo] INFO:FTP:[admin]@127.0.0.1:39537 
"pat1-dynamic.txt" received.
[2012-01-11 10:11:03,853][foo] INFO:FTP:[admin]@127.0.0.1:39537 Disconnected.
[2012-01-11 10:11:03,860][foo] INFO:FTP:[]127.0.0.1:39539 Connected.
[2012-01-11 10:11:03,864][foo] INFO:FTP:[admin]@127.0.0.1:39539 User admin 
logged in.
[2012-01-11 10:11:03,893][foo] INFO:FTP:[admin]@127.0.0.1:39539 OK CWD "/foo/".
[2012-01-11 10:11:03,912][foo] INFO:FTP:[admin]@127.0.0.1:39539 OK CWD 
"/foo/Documents/Partners Testing".
[2012-01-11 10:11:03,916][foo] WARNING:doc2.nodes:Attempted to create a file 
under collection@/Documents/Partners Testing, not possible.
[2012-01-11 10:11:03,918][foo] INFO:FTP:[admin]@127.0.0.1:39539 FAIL create()  
errno=1:  Not allowed to create files here.
[2012-01-11 10:11:03,920][foo] INFO:FTP:[admin]@127.0.0.1:39539 Disconnected.
[2012-01-11 10:11:03,920][foo] INFO:FTP:[]127.0.0.1:39541 Connected.
[2012-01-11 10:11:03,924][foo] INFO:FTP:[admin]@127.0.0.1:39541 User admin 
logged in.
[2012-01-11 10:11:03,951][foo] INFO:FTP:[admin]@127.0.0.1:39541 OK CWD "/foo/".
[2012-01-11 10:11:03,971][foo] INFO:FTP:[admin]@127.0.0.1:39541 OK CWD 
"/foo/Documents/Partners Testing".
[2012-01-11 10:11:03,973][foo] WARNING:doc2.nodes:Attempted to create a 
collection under collection@/Documents/Partners Testing, not possible.
[2012-01-11 10:11:03,974][foo] ERROR:FTP.fs:Cannot create dir "Weird folder" at 
node collection@/Documents/Partners Testing
Traceback (most recent call last):
  File 
"/home/openerp/openerp/addons/trunk-bug-document_ftp-sbh/document_ftp/ftpserver/abstracted_fs.py",
 line 230, in mkdir
    cdir = node.create_child_collection(cr, basename)
  File 
"/home/openerp/openerp/addons/trunk-bug-document_ftp-sbh/document/nodes.py", 
line 394, in create_child_collection
    raise IOError(errno.EPERM, "Not allowed to create folders here")
IOError: [Errno 1] Not allowed to create folders here

Can you please fix this?

Thanks,
Raphael
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-document_ftp-sbh/+merge/86517
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-document_ftp-sbh.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to