Review: Needs Fixing Hello Divyesh Makwana,
I just pushed an updated version of your branch (rev 5545). I cleaned the code and added some explanation on the algorithm. Could you please check that the test case is correctly solved ? Actually now _altern_si_so checks if it exists one previous and one next attendance record, compared to the record to be inserted. If the previous or next record has the same action, then the alternation is broken. If there is no previous or next record, it checks if this first record is indeed a sign_in. Could you also, as asked by Vo Minh Thu, write a test case to be added in hr_attendance test ? I suppose just adding a small test in attendance_process.yml should be sufficient. Best regards, Thibault. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-885387-mdi/+merge/86388 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-885387-mdi. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
