Review: Needs Fixing

In base_module_doc_rst/wizard/generate_relation_graph.py (line 119 of diff), 
couldn't you use context['active_ids'] instead of context['ids']?  This would 
simplify the corresponding action defined in 
base_module_doc_rst/wizard/generate_relation_graph_view.xml, as no explicit 
context would be required.

In base_module_doc_rst/wizard/tech_guide_rst.py (line 658 of diff), the 
dictionary _defaults is wrongly indented!  The file would always be empty, 
then.  Have you tested it?

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-914692-kjo/+merge/91209
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-914692-kjo.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to