Review: Approve

HEllo.

Right, the solution works so fine.

Just for Records.

This part. (decisition of picking) should be done in an external method, 

8       + reception_address_id = False
9       for order in self.browse(cr, uid, ids):
10      + if order.dest_address_id:
11      + reception_address_id = order.dest_address_id.id
12      + elif order.warehouse_id and order.warehouse_id.partner_address_id:
13      + reception_address_id = order.warehouse_id.partner_address_id.id
14      + else:
15      + if order.company_id.partner_id.address:
16      + addresses_default = [address.id for address in 
order.company_id.partner_id.address if address.type == 'default']
17      + addresses_delivery = [address.id for address in 
order.company_id.partner_id.address if address.type == 'delivery']
18      + reception_address_id = (addresses_delivery and addresses_delivery[0]) 
or (addresses_default and addresses_default[0]) or False


this refactor can be done for TRUNK, IMHO: In this way you can overwrite JUST 
this decisition depending of business needs more easy.

Regards.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-381630-rgo/+merge/90042
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-381630-rgo.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to