Review: Needs Fixing

Thought of two more issues regarding this:

1. There are more usages of the on_ and do_ methods than in views.js, those 
other callsites need to be checked for their semantics and fixed if they're now 
broken (especially those with `unique:true`, unless the event-based callback is 
fixed to handle this, which it could be)

2. Needs a basic change note explaining why the callbacks API was changed and 
how the new do_ and on_ methods work (and maybe making clear that on_ and do_ 
methods should not be used for new APIs? Should new APIs use events directly or 
should they use the on_ and do_ stuff?) since their behavior changed quite 
drastically (and split)
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-event-refactoring-al/+merge/91377
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-event-refactoring-al.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to