> * I think we need to check the msgcat output (either the return value or the > output file) [...]
I fixed that by passing --force-po to msgcat in order to force the creation of the output file event if it is an empty "catalog". > * The sh extraction script should probably stick to one style of command > substitutions, ideally $(). Line 38 mixes $() and backticks, and line 42 uses > backticks, both should use $(). Sure > * It should also check that the system has `msgcat` available before starting > its work (at least in $do_all mode), most systems don't have the `gettext` > suite installed by default. Good point, now checking for msgcat in PATH in do_all mode. > * Maybe the qweb extraction thingie could use `iterparse` (and the (end) > event) instead of reimplementing it? Could be a separate improvement though, > but while we're at it… removes half the lines for iterating the object tree This would in fact increase code complexity because we need the iteration to skip elements with all their descendants, something that does not appear trivial to write with iterparse (not supposed to alter untraversed parts of the tree while iterating). Added a comment in that sense. Thanks for the review :-) -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-i18n-addons-unification/+merge/91287 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-i18n-addons-unification. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
