Rifakat (OpenERP) has proposed merging 
lp:~openerp-dev/openobject-addons/6.0-opw-383609-rha into 
lp:openobject-addons/6.0.

Requested reviews:
  Naresh(OpenERP) (nch-openerp)
Related bugs:
  Bug #931748 in OpenERP Addons: "[account_voucher] Account voucher doesn't 
change number"
  https://bugs.launchpad.net/openobject-addons/+bug/931748

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-383609-rha/+merge/92928

Hello,

While we cancel any voucher, set it in draft state, number field does not get 
updated based on journal selected. It keeps old number reference if we post 
voucher with other journal.

I have put number field blank while canceling any voucher so that every time 
number field will be saved based on sequence of selected journal.

Please review this.

Regards,
Rifakat
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-383609-rha/+merge/92928
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-383609-rha.
=== modified file 'account_voucher/account_voucher.py'
--- account_voucher/account_voucher.py	2012-02-10 15:32:50 +0000
+++ account_voucher/account_voucher.py	2012-02-14 08:36:21 +0000
@@ -612,6 +612,7 @@
         res = {
             'state':'cancel',
             'move_id':False,
+            'number': ''
         }
         if invoice_ids:
             wf_service.trg_validate(uid, 'account.invoice', invoice_ids[0], 'open_test', cr)
@@ -665,9 +666,7 @@
             context_multi_currency = context.copy()
             context_multi_currency.update({'date': inv.date})
 
-            if inv.number:
-                name = inv.number
-            elif inv.journal_id.sequence_id:
+            if inv.journal_id.sequence_id:
                 name = seq_obj.get_id(cr, uid, inv.journal_id.sequence_id.id)
             if not name:
                 raise osv.except_osv(_('Error !'), _('Please define a sequence on the journal and make sure it is activated !'))

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to