Cecile Tonglet (OpenERP) has proposed merging
lp:~openerp-dev/openobject-server/trunk-simplify-boolean-in-config-files-cto
into lp:openobject-server.
Requested reviews:
OpenERP Core Team (openerp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-simplify-boolean-in-config-files-cto/+merge/93944
I remove the specific code to detect booleans in config parsing and replace it
with the built-in feature 'getboolean' in module ConfigParser.
That enable the user to set values to 'yes', 'true', 1, 'on', 'True' to make
boolean.
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-simplify-boolean-in-config-files-cto/+merge/93944
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-simplify-boolean-in-config-files-cto.
=== modified file 'openerp/tools/config.py'
--- openerp/tools/config.py 2012-02-10 14:41:14 +0000
+++ openerp/tools/config.py 2012-02-21 09:27:54 +0000
@@ -550,24 +550,22 @@
p = ConfigParser.ConfigParser()
try:
p.read([self.rcfile])
- for (name,value) in p.items('options'):
- if value=='True' or value=='true':
- value = True
- if value=='False' or value=='false':
- value = False
- self.options[name] = value
+ for key in p.options('options'):
+ try:
+ self.options[key] = p.getboolean('options', key)
+ except ValueError:
+ self.options[key] = p.get('options', key)
#parse the other sections, as well
for sec in p.sections():
if sec == 'options':
continue
if not self.misc.has_key(sec):
self.misc[sec]= {}
- for (name, value) in p.items(sec):
- if value=='True' or value=='true':
- value = True
- if value=='False' or value=='false':
- value = False
- self.misc[sec][name] = value
+ for key in p.options(sec):
+ try:
+ self.misc[sec][key] = p.getboolean('options', key)
+ except ValueError:
+ self.misc[sec][key] = p.get('options', key)
except IOError:
pass
except ConfigParser.NoSectionError:
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
