Review: Disapprove

Ravish(OpenERP) (rmu-openerp) wrote 1 hour ago: "As you suggested that all 
field should be read only .But when I want to create picking from "incoming 
shipment" that time I need all provide selection options.so this fix committed 
is perfect for now."

This is far from perfect.

First, you don't even need this field displayed at all, because there is a 
dedicated view and menu entry for each value.
Second, I don't understand why you "need all provide selection options". 
Functionally it's useless, so is it for technical reasons? In that case, you 
must allow changes only in the draft state. Users changing confirmed or 
assigned moves would be very wrong.
Lionel.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-937077-mma/+merge/93933
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-937077-mma.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to