Review: Needs Fixing

* We should probably remove the #dia-canvas (id) and into the DOM via selection 
rooted on $element, since Raphael can handle it

* After discussing with odo, we'll display the diagrammed object's name. It's 
available on result.id_model currently but not very well done so we'll rename 
it (also it does a `read` on `name` instead of doing a `name_get`)

* If the computer/mouse's scrolling is a bit fast, it's very easy to get the 
diagram to disappear altogether through jquery-mousewheel.

* Code indentation/whitespacing looks a bit weird, e.g. diagram.js:165, not 
consistent with usual code.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-new-diagram-fva/+merge/95130
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-new-diagram-fva.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to