Bharat Devnani (Open ERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-partner-address-cleaning-stock-bde into
lp:~openerp-dev/openobject-addons/trunk-partner-address-cleaning.
Requested reviews:
OpenERP R&D Team (openerp-dev)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-partner-address-cleaning-stock-bde/+merge/96080
Hello Madam,
I have removed the references of res.partner.address from stock module.
Thanks & Regards,
Devnani Bharat R.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-partner-address-cleaning-stock-bde/+merge/96080
Your team OpenERP R&D Team is requested to review the proposed merge of
lp:~openerp-dev/openobject-addons/trunk-partner-address-cleaning-stock-bde into
lp:~openerp-dev/openobject-addons/trunk-partner-address-cleaning.
=== modified file 'stock/report/report_stock_move.py'
--- stock/report/report_stock_move.py 2012-03-05 11:03:46 +0000
+++ stock/report/report_stock_move.py 2012-03-06 09:12:18 +0000
@@ -35,7 +35,7 @@
'month':fields.selection([('01','January'), ('02','February'), ('03','March'), ('04','April'),
('05','May'), ('06','June'), ('07','July'), ('08','August'), ('09','September'),
('10','October'), ('11','November'), ('12','December')], 'Month',readonly=True),
- 'partner_id':fields.many2one('res.partner.address', 'Partner', readonly=True),
+ 'partner_id':fields.many2one('res.partner', 'Partner', readonly=True),
'product_id':fields.many2one('product.product', 'Product', readonly=True),
'company_id':fields.many2one('res.company', 'Company', readonly=True),
'picking_id':fields.many2one('stock.picking', 'Packing', readonly=True),
@@ -154,7 +154,7 @@
'year': fields.char('Year', size=4, readonly=True),
'month':fields.selection([('01','January'), ('02','February'), ('03','March'), ('04','April'),
('05','May'), ('06','June'), ('07','July'), ('08','August'), ('09','September')]),
- 'partner_id':fields.many2one('res.partner.address', 'Partner', readonly=True),
+ 'partner_id':fields.many2one('res.partner', 'Partner', readonly=True),
'product_id':fields.many2one('product.product', 'Product', readonly=True),
'product_categ_id':fields.many2one('product.category', 'Product Category', readonly=True),
'location_id': fields.many2one('stock.location', 'Location', readonly=True),
=== modified file 'stock/stock.py'
--- stock/stock.py 2012-03-05 13:25:39 +0000
+++ stock/stock.py 2012-03-06 09:12:18 +0000
@@ -646,8 +646,7 @@
store=True, type='datetime', string='Max. Expected Date', select=2),
'move_lines': fields.one2many('stock.move', 'picking_id', 'Internal Moves', states={'done': [('readonly', True)], 'cancel': [('readonly', True)]}),
'auto_picking': fields.boolean('Auto-Picking'),
- 'address_id': fields.many2one('res.partner.address', 'Address', help="Address of partner"),
- 'partner_id': fields.related('address_id','partner_id',type='many2one',relation='res.partner',string='Partner',store=True),
+ 'address_id': fields.many2one('res.partner', 'Address', help="Address of partner"),
'invoice_state': fields.selection([
("invoiced", "Invoiced"),
("2binvoiced", "To Be Invoiced"),
@@ -877,7 +876,7 @@
@param picking: object of the picking for which we are selecting the partner to invoice
@return: object of the partner to invoice
"""
- return picking.address_id and picking.address_id.partner_id
+ return picking.address_id and picking.address_id.id
def _get_comment_invoice(self, cr, uid, picking):
"""
@@ -917,11 +916,11 @@
else:
taxes = move_line.product_id.taxes_id
- if move_line.picking_id and move_line.picking_id.address_id and move_line.picking_id.address_id.partner_id:
+ if move_line.picking_id and move_line.picking_id.address_id and move_line.picking_id.address_id.id:
return self.pool.get('account.fiscal.position').map_tax(
cr,
uid,
- move_line.picking_id.address_id.partner_id.property_account_position,
+ move_line.picking_id.address_id.property_account_position,
taxes
)
else:
@@ -981,6 +980,7 @@
@param journal_id: ID of the accounting journal
@return: dict that will be used to create the invoice object
"""
+ partner = self.pool.get('res.partner').browse(cr, uid, partner, context=context)
if inv_type in ('out_invoice', 'out_refund'):
account_id = partner.property_account_receivable.id
else:
@@ -995,8 +995,6 @@
'type': inv_type,
'account_id': account_id,
'partner_id': partner.id,
- 'address_invoice_id': address_invoice_id,
- 'address_contact_id': address_contact_id,
'comment': comment,
'payment_term': partner.property_payment_term and partner.property_payment_term.id or False,
'fiscal_position': partner.property_account_position.id,
@@ -1099,7 +1097,7 @@
else:
invoice_vals = self._prepare_invoice(cr, uid, picking, partner, inv_type, journal_id, context=context)
invoice_id = invoice_obj.create(cr, uid, invoice_vals, context=context)
- invoices_group[partner.id] = invoice_id
+ invoices_group[partner] = invoice_id
res[picking.id] = invoice_id
for move_line in picking.move_lines:
if move_line.state == 'cancel':
@@ -1580,7 +1578,7 @@
'location_id': fields.many2one('stock.location', 'Source Location', required=True, select=True,states={'done': [('readonly', True)]}, help="Sets a location if you produce at a fixed location. This can be a partner location if you subcontract the manufacturing operations."),
'location_dest_id': fields.many2one('stock.location', 'Destination Location', required=True,states={'done': [('readonly', True)]}, select=True, help="Location where the system will stock the finished products."),
- 'address_id': fields.many2one('res.partner.address', 'Destination Address ', states={'done': [('readonly', True)]}, help="Optional address where goods are to be delivered, specifically used for allotment"),
+ 'address_id': fields.many2one('res.partner', 'Destination Address ', states={'done': [('readonly', True)]}, help="Optional address where goods are to be delivered, specifically used for allotment"),
'prodlot_id': fields.many2one('stock.production.lot', 'Production Lot', states={'done': [('readonly', True)]}, help="Production lot is used to put a serial number on the production", select=True),
'tracking_id': fields.many2one('stock.tracking', 'Pack', select=True, states={'done': [('readonly', True)]}, help="Logistical shipping unit: pallet, box, pack ..."),
@@ -1598,7 +1596,6 @@
'price_unit': fields.float('Unit Price', digits_compute= dp.get_precision('Account'), help="Technical field used to record the product cost set by the user during a picking confirmation (when average price costing method is used)"),
'price_currency_id': fields.many2one('res.currency', 'Currency for average price', help="Technical field used to record the currency chosen by the user during a picking confirmation (when average price costing method is used)"),
'company_id': fields.many2one('res.company', 'Company', required=True, select=True),
- 'partner_id': fields.related('picking_id','address_id','partner_id',type='many2one', relation="res.partner", string="Partner", store=True, select=True),
'backorder_id': fields.related('picking_id','backorder_id',type='many2one', relation="stock.picking", string="Back Order", select=True),
'origin': fields.related('picking_id','origin',type='char', size=64, relation="stock.picking", string="Origin", store=True),
@@ -1667,9 +1664,9 @@
except:
pass
elif context.get('address_in_id', False):
- part_obj_add = self.pool.get('res.partner.address').browse(cr, uid, context['address_in_id'], context=context)
- if part_obj_add.partner_id:
- location_id = part_obj_add.partner_id.property_stock_supplier.id
+ part_obj_add = self.pool.get('res.partner').browse(cr, uid, context['address_in_id'], context=context)
+ if part_obj_add:
+ location_id = part_obj_add.property_stock_supplier.id
else:
location_xml_id = False
if picking_type == 'in':
@@ -1815,9 +1812,9 @@
return {}
lang = False
if address_id:
- addr_rec = self.pool.get('res.partner.address').browse(cr, uid, address_id)
+ addr_rec = self.pool.get('res.partner').browse(cr, uid, address_id)
if addr_rec:
- lang = addr_rec.partner_id and addr_rec.partner_id.lang or False
+ lang = addr_rec and addr_rec.lang or False
ctx = {'lang': lang}
product = self.pool.get('product.product').browse(cr, uid, [prod_id], context=ctx)[0]
@@ -1857,7 +1854,7 @@
cr,
uid,
m.location_dest_id,
- m.picking_id and m.picking_id.address_id and m.picking_id.address_id.partner_id,
+ m.picking_id and m.picking_id.address_id and m.picking_id.address_id.id,
m.product_id,
context
)
@@ -2264,7 +2261,7 @@
processing of the given stock move.
"""
# prepare default values considering that the destination accounts have the reference_currency_id as their main currency
- partner_id = (move.picking_id.address_id and move.picking_id.address_id.partner_id and move.picking_id.address_id.partner_id.id) or False
+ partner_id = (move.picking_id.address_id and move.picking_id.address_id.id and move.picking_id.address_id.id) or False
debit_line_vals = {
'name': move.name,
'product_id': move.product_id and move.product_id.id or False,
@@ -2672,7 +2669,6 @@
pid = line.product_id.id
product_context.update(uom=line.product_uom.id, date=inv.date, prodlot_id=line.prod_lot_id.id)
amount = location_obj._product_get(cr, uid, line.location_id.id, [pid], product_context)[pid]
-
change = line.product_qty - amount
lot_id = line.prod_lot_id.id
if change:
@@ -2684,6 +2680,7 @@
'prodlot_id': lot_id,
'date': inv.date,
}
+
if change > 0:
value.update( {
'product_qty': change,
@@ -2775,7 +2772,7 @@
_columns = {
'name': fields.char('Name', size=128, required=True, select=True),
'company_id': fields.many2one('res.company', 'Company', required=True, select=True),
- 'partner_address_id': fields.many2one('res.partner.address', 'Owner Address'),
+ 'partner_address_id': fields.many2one('res.partner', 'Owner Address'),
'lot_input_id': fields.many2one('stock.location', 'Location Input', required=True, domain=[('usage','<>','view')]),
'lot_stock_id': fields.many2one('stock.location', 'Location Stock', required=True, domain=[('usage','=','internal')]),
'lot_output_id': fields.many2one('stock.location', 'Location Output', required=True, domain=[('usage','<>','view')]),
=== modified file 'stock/stock_view.xml'
--- stock/stock_view.xml 2012-01-31 13:36:57 +0000
+++ stock/stock_view.xml 2012-03-06 09:12:18 +0000
@@ -343,7 +343,6 @@
<tree string="Stock Moves">
<field name="picking_id" string="Reference"/>
<field name="origin"/>
- <field name="partner_id"/>
<field name="product_id"/>
<field name="product_qty" on_change="onchange_quantity(product_id, product_qty, product_uom, product_uos)"/>
<field name="product_uom" string="UoM"/>
@@ -673,7 +672,6 @@
<field name="arch" type="xml">
<tree colors="blue:state == 'draft';grey:state == 'cancel';red:state not in ('cancel', 'done') and date < current_date" string="Picking list">
<field name="name"/>
- <field name="partner_id" invisible="True"/>
<field name="backorder_id" groups="base.group_extended"/>
<field name="origin"/>
<field name="date"/>
@@ -843,7 +841,6 @@
</group>
<newline/>
<group expand="0" string="Group By...">
- <filter string="Partner" icon="terp-partner" domain="[]" context="{'group_by':'partner_id'}"/>
<separator orientation="vertical" />
<filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
<separator orientation="vertical" />
@@ -867,7 +864,6 @@
<field name="arch" type="xml">
<tree colors="blue:state == 'draft';grey:state == 'cancel';red:state not in ('cancel', 'done') and min_date < current_date" string="Delivery Orders">
<field name="name"/>
- <field name="partner_id"/>
<field name="origin"/>
<field name="date"/>
<field name="min_date"/>
@@ -1030,14 +1026,12 @@
<filter icon="terp-dolar" name="to_invoice" string="To Invoice" domain="[('invoice_state','=','2binvoiced')]" help="Delivery orders to invoice"/>
<separator orientation="vertical"/>
<field name="name"/>
- <field name="partner_id" />
<field name="origin"/>
<field name="stock_journal_id" groups="base.group_extended" widget="selection"/>
<field name="company_id" widget="selection" groups="base.group_multi_company"/>
</group>
<newline/>
<group expand="0" string="Group By...">
- <filter string="Partner" icon="terp-partner" domain="[]" context="{'group_by':'partner_id'}"/>
<separator orientation="vertical" />
<filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
<separator orientation="vertical" />
@@ -1087,7 +1081,6 @@
<field name="arch" type="xml">
<tree colors="blue:state == 'draft';grey:state == 'done';red:state not in ('cancel', 'done') and date < current_date" string="Picking list">
<field name="name"/>
- <field name="partner_id" />
<field name="backorder_id" groups="base.group_extended"/>
<field name="origin"/>
<field name="date"/>
@@ -1110,7 +1103,7 @@
<group colspan="4" col="4">
<field name="name" readonly="1"/>
<field name="origin"/>
- <field name="address_id" on_change="onchange_partner_in(address_id)" context="{'contact_display':'partner'}" domain="[('partner_id','<>',False)]" colspan="4"/>
+ <field name="address_id" on_change="onchange_partner_in(address_id)" context="{'contact_display':'partner'}" colspan="4"/>
<field name="invoice_state" string="Invoice Control"/>
<field name="backorder_id" readonly="1" groups="base.group_extended"/>
</group>
@@ -1246,14 +1239,12 @@
<filter string="To invoice" name="to_invoice" icon="terp-dolar" domain="[('invoice_state', '=', '2binvoiced')]" />
<separator orientation="vertical"/>
<field name="name"/>
- <field name="partner_id"/>
<field name="origin"/>
<field name="stock_journal_id" groups="base.group_extended" widget="selection"/>
<field name="company_id" widget="selection" groups="base.group_multi_company" />
</group>
<newline/>
<group expand="0" string="Group By...">
- <filter string="Partner" icon="terp-partner" domain="[]" context="{'group_by':'partner_id'}"/>
<separator orientation="vertical" />
<filter icon="terp-stock_effects-object-colorize" name="state" string="State" domain="[]" context="{'group_by':'state'}"/>
<separator orientation="vertical" />
@@ -1367,7 +1358,6 @@
<field name="picking_id" string="Reference"/>
<field name="origin"/>
<field name="create_date" invisible="1"/>
- <field name="partner_id"/>
<field name="product_id"/>
<field name="product_qty" on_change="onchange_quantity(product_id, product_qty, product_uom, product_uos)"/>
<field name="product_uom" string="UoM"/>
@@ -1541,7 +1531,6 @@
<tree colors="grey:state == 'cancel'" string="Moves">
<field name="picking_id" string="Reference"/>
<field name="origin"/>
- <field name="partner_id" string="Partner"/>
<field name="product_id"/>
<field name="product_qty" />
<field name="product_uom" string="UoM"/>
@@ -1580,7 +1569,6 @@
<field name="arch" type="xml">
<tree string="Moves">
<field name="picking_id" string="Reference"/>
- <field name="partner_id" string="Partner"/>
<field name="product_id"/>
<field name="product_qty" />
<field name="product_uom" string="UoM"/>
@@ -1676,13 +1664,11 @@
<filter icon="terp-go-today" string="Today" domain="[('date','<=',time.strftime('%%Y-%%m-%%d 23:59:59')),('date','>=',time.strftime('%%Y-%%m-%%d 00:00:00'))]" help="Orders planned for today"/>
<separator orientation="vertical"/>
<field name="origin"/>
- <field name="partner_id" string="Partner"/>
<field name="product_id"/>
<field name="prodlot_id"/>
</group>
<newline/>
<group expand="0" string="Group By..." groups="base.group_extended">
- <filter string="Supplier" icon="terp-personal" domain="[]" context="{'group_by':'partner_id'}"/>
<filter string="Product" icon="terp-accessories-archiver" domain="[]" context="{'group_by':'product_id'}"/>
<separator orientation="vertical"/>
<filter string="Order" icon="terp-gtk-jump-to-rtl" domain="[]" context="{'group_by':'origin'}"/>
@@ -1709,13 +1695,11 @@
<filter icon="terp-go-today" string="Today" domain="[('date','<=',time.strftime('%%Y-%%m-%%d 23:59:59')),('date','>=',time.strftime('%%Y-%%m-%%d 00:00:00'))]" help="Orders planned for today"/>
<separator orientation="vertical"/>
<field name="origin"/>
- <field name="partner_id" string="Partner"/>
<field name="product_id"/>
<field name="prodlot_id"/>
</group>
<newline/>
<group expand="0" string="Group By..." groups="base.group_extended">
- <filter string="Customer" icon="terp-personal" domain="[]" context="{'group_by':'partner_id'}"/>
<separator orientation="vertical"/>
<filter string="Product" icon="terp-accessories-archiver" domain="[]" context="{'group_by':'product_id'}"/>
<filter string="Order" icon="terp-gtk-jump-to-rtl" domain="[]" context="{'group_by':'origin'}"/>
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
