Review: Needs Fixing
Hi,
I've got multiple remarks here:
1. In view "view_vendor_payment_form", domain for <field name=""account_id"/>
inside "line_cr_ids" inline tree view should be set to
"[('type','=','payable')]"
Currently it filter on "receivable" which is wrong in that context (payment),
that's a bug which is fixed in trunk - so we should also fix this, even if it's
not the purpose of the OPW :)
2. Missing "type" in context is only added in 1 place, you should look all
"line_cr_ids" and "line_dr_ids", as there are some more missing
3. The fields_view_get currently doesn't handle the following cases:
- view id "view_vendor_receipt_form", field "line_dr_ids" (default_type = 'dr',
type = 'receipt') => [('type','=','receivable')]
- view id "view_vendor_payment_form", field "line_cr_ids" (default_type = 'cr',
type = 'payment') => [('type','=','payable')] (as statement in 1.)
4. Could you make sure fields_view_get only change domain on "form" view, keep
other view as is (check for view_type == 'form')
Many thanks,
Xavier
--
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-32677-rha/+merge/81821
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/6.0-opw-32677-rha.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
