Review: Needs Fixing Hi,
I'm not pretty happy adding new onchange(), but I think it's the cleaner way of doing it, so I'm ok. But I have two remarks: 1. onchange_date() is declared inside "account" module, but it make reference to "account.voucher" [from "account_voucher"], that should not happen because account_voucher depend on account, if account_voucher is not installed that will fail. Perhaps, declare an empty onchange_date() inside "account" module, returning empty dict. Then inherit that inside account_voucher module. 2. The validation inside account_voucher will fail everytime bank statement line's "date" <> statement's "date". 73 + if st_line.statement_id.date != st_line.voucher_id.date: 76 + if st_line.date != st_line.voucher_id.date: Better keep only the 2nd one (Line 76) as onchange will update the voucher date based on statement line information. Thanks, Xavier -- https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-381537-rha/+merge/89641 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-opw-381537-rha. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
