Review: Approve mostly functional

FWIW, seems to work well for me on runbot, and definitely represents a great 
usability improvement for multi-tab browsing. I would not particularly miss the 
"version_label" tailing the title, especially as it is already present in the 
footer and few people will ever get to read it in the title as it's way too 
long.
Any objection to that, anyone?

Other minor remarks:
- l.27-29, you can completely drop that 'version_label' var now, can't you?
- it works well when clicking on menus or related links in sidebar, but does 
not seem to catch the change when opening a many2one in full screen - is there 
a way to do this without getting false positives for popups?
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-webclient.set_title-chs/+merge/96619
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-webclient.set_title-chs.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to