Review: Approve Nicely done!
Just a few things (I can do them when doing the merge): - Don't comment the reason you `import` things. This is nice at first but not sufficiently/uniformly done to have a clear advantage. - I don't really care about the `mini` naming, but at least call it thumbnail or something similar in the field label, a help string to say that the value is automatically computed from the other field would be nice too. (Maybe call it just Avatar instead of User Avatar?) - Again, information about the binary field would be nice (to know it is base64 encoded (PIL-supported) image). - Importing `random` is enough to initialize its seed. No need to call seed(). Thanks a lot for the .rst doc! -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-user_img-tde/+merge/97184 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-user_img-tde. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
