Review: Needs Fixing
Hello,
It becomes good ! I still have some remarks.
- The first one is that there is a lot of "has been <b>...</b>". I just pushed
a newer version of your branch, with default messages in crm_base. If a
'msg_prefix' value is set in context, it is added as a prefix (i.e.,
Opportunity has been <b>opened</b>, the prefix is Opportunity). I updated
crm_lead methods just to test and see how to use it. Please propagate those
changes in crm.
- When I renew a lead, I have the message twice ... must be a method called
twice somewhere, place check :) .
- On Lead / Opp form view, there is a button 'Send new e-mail' (below schedule
meeting) and a button 'Mail' (near the contact). As they do the same, please
remove the one below the actions.
- Some other remarks ...
**crm.py**
- case_open (in crm_base and crm_case): no need to call case_open_send_note in
every iteration of the loop, as the method work on ids.
**crm_meeting.py**
- case_create_send_note: rename to create_send_note.
**crm_lead**
- case_create_send_note -> create_send_note
- case_open: you forgot a condition from the initial file, this may cause side
issues ! Check the original case_open
(# When coming from draft override date and stage otherwise just set state
if l.state == 'draft':)
- _merge_notification: your return 'opportunity.message_append_note(subject,
body=details)' is not good, as the message must be sent to opportunity_id, not
the last from opportunities (check original method)
- case_partner_send_note -> _lead_set_partner_send_note
- case_phonecall_send_note -> schedule_phonecall_send_note
Best regards,
Thibault.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-social-crm-bth/+merge/96754
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-social-tde.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
