Review: Needs Fixing
Hello Mayur,
You can still optimize the code of fields_view_get method for
stock.partial.picking.line.
e.g:
instead of
for field in res['fields']:
You can directly use
for node in doc.xpath("//group/button[@string='_Validate']"):
and the logic for updating the separator string is not good.
try to use same logic for it as u have done for button string instead of using
extra variable separator_extended = ''
thanks,
Purnendu Singh
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-stock_picking_usability-mma/+merge/98358
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-stock_picking_usability.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
