Review: Needs Fixing

Hello,

Some comments :
- case_open_send_note: not necessary because same as defined in crm_base
- in crease_send_note: not necessary to loop over ids, as you can give directly 
ids to message_append_note
- get_needaction_user_ids: the second if will erase the first one; what is the 
required fucntionality ? user_id and project_id.user_id if obj in draft mode, 
or user_id if draft and project_id.user_id always ?
- case_reset: do not call case_reset_send_note, as it will be automatically 
called in the super( method

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-social-project_issue-jra/+merge/97606
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-social-tde.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to