Review: Disapprove

How does this fix the issue... ?

list.pop tends to receive an index in your case you are passing 'user_id' which 
can be any number generated by the system and not the value.

for eg:

your children list has values [21,33,44,55] and user_id = 33 

now doing children.pop(33) will crash "IndexError: pop index out of range"

can you please re review your fix.

Thanks,
Naresh
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-383477-han/+merge/92209
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-383477-han.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to