Review: Needs Fixing

Hello Amit,

I still disagree with that MP:

- L16-L32: product account mapping should be done per-line, not only once. Here 
"new_acc" mapping is done 1 time
- L33-L34: ppdating all exisitng account.invoice.line with the same account_id 
is not right, different product could make different accounts

So basically, for each existing account.invoice.line on "invoice_created",
- if product_id is defined, find original 'account_id' then apply mapping on it.
- if no product_id, apply mapping on the exising 'account_id'

Could you please update this,

Cheers,
Xavier
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-51169-ado/+merge/86505
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-51169-ado.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to