Mohammed Shekha(Open ERP) has proposed merging
lp:~openerp-dev/openerp-web/6.1-opw-572829-msh into lp:openerp-web/6.1.
Requested reviews:
OpenERP Core Team (openerp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-572829-msh/+merge/99468
Hello,
Fixed the issue of blank record created in customer form -> contact one2many
field.
Here in (!self.datarecord.id || f.is_dirty()) when there is no datarecord.id at
that time it will not going to check for is_dirty and will always get all the
field, wheather is changed or not changed, hence it creates empty record in
contact.
Thanks.
--
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-572829-msh/+merge/99468
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/6.1-opw-572829-msh.
=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js 2012-03-05 19:58:00 +0000
+++ addons/web/static/src/js/view_form.js 2012-03-27 05:46:19 +0000
@@ -497,7 +497,7 @@
if (!first_invalid_field) {
first_invalid_field = f;
}
- } else if (f.name !== 'id' && !f.readonly && (!self.datarecord.id || f.is_dirty())) {
+ } else if (f.name !== 'id' && !f.readonly && (!self.datarecord.id || f.is_dirty()) && f.is_dirty()) {
// Special case 'id' field, do not save this field
// on 'create' : save all non readonly fields
// on 'edit' : save non readonly modified fields
@@ -510,7 +510,7 @@
return $.Deferred().reject();
} else {
var save_deferral;
- if (!self.datarecord.id) {
+ if (!self.datarecord.id && !_.isEmpty(values)) {
//console.log("FormView(", self, ") : About to create", values);
save_deferral = self.dataset.create(values).pipe(function(r) {
return self.on_created(r, undefined, prepend_on_create);
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
