Review: Needs Fixing

Hello Ila,

Two things that needd to be fixed:

- You're reading the "company_id" in an account.analytic.account, but the 
"company_id" field is not required on that object, so make sure there is one, 
otherwise the final "company[0]" will crash.

- You should move that code into "hr_timesheet" module, because here we're 
inheriting from "hr.analytic.timesheet" object, and your code don't depend on 
new fields introduce by "hr_timesheet_sheet" module.

Regards,
Xavier
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-57608-ira/+merge/93344
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-57608-ira.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to