Review: Needs Fixing

* why isn't this handled as an actual widget in the registry?
* many fields can have widgets which are simply used to nicely display them, 
skipping any field with a @widget set is going to break many forms
* what's with the weird capitalizing in the CSS class, why does Nopadding get a 
titlecase?
* also the whitespace in the introduced CSS is very inconsistent (spaces before 
commas, no spaces before braces), and some tabs are used even though all 
indentation should be done with spaces, variable-size indentation)
* are the additional CSS rules really necessary, can't the base rule cascade on 
its own?
* i'm quite doubtful that td.render() only ever generates inline elements, and 
spans can only contain inline elements, I'm guessing something's going to break
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-newgeneric_widget-dhr/+merge/99479
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-newgeneric_widget-dhr.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to