Mohammed Shekha(Open ERP) has proposed merging
lp:~openerp-dev/openobject-client-web/6.0-bug-962025-msh into
lp:openobject-client-web.
Requested reviews:
OpenERP Core Team (openerp)
Related bugs:
Bug #962025 in OpenERP Web Client: "[Regression] Due to rev no4776 :
AttributeError on Sales Dashboard"
https://bugs.launchpad.net/openobject-client-web/+bug/962025
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-bug-962025-msh/+merge/101170
Hello,
Fixed the regression in web-client which comes due to revision 4776.
Demo :- Sale -> Sales Dashboard -> Change the Stage it gives traceback that int
object doesn't have split method.
The traceback occurs due to revision 4776, here in 4776 we have set the
current.limit, now current have some data, so the line no. 174 in _o2m.py
becomes true, but we have not checked here that whether params.source is
basestring or not.
before revision 4776 this was not raising an issue because current was coming
{}, so from there the if condition stops for further checking.
Hence changed the code to fix the issue.
Thanks.
--
https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-bug-962025-msh/+merge/101170
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-client-web/6.0-bug-962025-msh.
=== modified file 'addons/openerp/widgets/form/_o2m.py'
--- addons/openerp/widgets/form/_o2m.py 2012-02-14 06:12:27 +0000
+++ addons/openerp/widgets/form/_o2m.py 2012-04-07 10:31:19 +0000
@@ -171,7 +171,7 @@
limit = 0
ids = rpc.RPCProxy(self.model).search(domain, current.offset, limit, params.sort_key + ' '+params.sort_order, current.context)
id = ids[0]
- if current and params.source and self.name in params.source.split('/'):
+ if current and params.source and isinstance(params.source, basestring) and self.name in params.source.split('/'):
id = current.id
id = id or None
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp