Hi, As I am doing a branch holding the improvements/fixes/changes in mail module from trunk-form-v2-fme, I will include answers to your review (see trunk-social-review-tde, currently in WIP).
"- l.68: the configuration of email servers seems like a vital thing for most admins to go through, so I am wondering why that menu is now hidden by default for all users? Is it replaced by something equivalent? Making the parent menu visible does not seem like a reason to cripple the email config this way?" The parent menu was accessible only in extended view. As this view is supposed to be removed, the mail server configuration is moved into the technical features group. The menu itself instead of the parent is now in technical group. Being in the technical group seems to match the email servers configuration feature, but we can set it as visible by default for all users having access to the Settings menu if it is clearer at usability point of view. "- l.95-96: it looks like this should have been fixed before merging..." * looks on the left, looks on the right, finds a tree, hides itself behind the tree * No one's here ! "- l.82, l.424: these mentions of "OpenChatter" without referring to any pointer might not be very helpful for developers... I don't see any "OpenChatter" module that they could look into." Indeed. (with Teal'c voice) "- l.424: why not provide some convenient backwards-compatible mechanism that will create an actual mail.message if log() is called on a message that inherits from mail.thread, like it used to do it? When deprecating features we usually try to keep them working with a deprecation warning during one release before removing them completely." Actually the mail module overrides the log method. As soon as you install the mail module, all remaining res logs will be converted into mail.message records (with a warning to tell you to use the chatter feature). However, you are right saying that if you do not install the mail module, you loose the res.log feature. Actually we can choose several options : - as the mail module is quickly installed because it is a dependency of a lot of main modules, leave as it is - restore the res.log feature for the next version with a warning about deprecation - move the (maybe simplified) mail.message model into the server base module (as evoked with al), because having a message model seems to be one of the basic functionality that you can imagine having when using only the server. This option is the one I prefer, but I leave to the core experts the choice of what features you want into the server. Thanks, Thibault. -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-social-tde/+merge/100668 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-social-tde. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
