Review: Needs Fixing
* Please fix indentation, how the bloody hell do you manage to fuck up the
indentation of a line which is already there? `var context = _.extend({},
record.attributes, {` was correctly indented with 4 spaces how did you manage
to mis-indent the exact same line to 3 spaces?
* Use a switch, not a bunch of ifs, to dispatch between the keys (and don't
forget break)
* Styles accumulation is not correct: if the user specifies both bold and
italic only italic will stick
* Why add the color to `style` in-place instead of just returning the
concatenation directly?
* Why not have `style` be an array, and use `join(';')` when returning it? That
way you'd avoid string concatenations everywhere
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-social-list-tpa/+merge/102274
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-social-list-tpa.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
