Amit Parik (OpenERP) has proposed merging 
lp:~openerp-dev/openobject-addons/trunk-bug-960158-amp into 
lp:openobject-addons.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #960158 in OpenERP Addons: "Account_change should be override the product 
tax to account tax if product tax assigned on product"
  https://bugs.launchpad.net/openobject-addons/+bug/960158

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-960158-amp/+merge/103863

Hello,

Product tax should be override the account tax because it creates a problem on 
web client.When product_id change will call from invoice line on web it also 
call the account_change and add the account tax on product tax instead of 
override.

This fix will solved this problem!


Cheers!
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-960158-amp/+merge/103863
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-960158-amp.
=== modified file 'account/account_invoice.py'
--- account/account_invoice.py	2012-04-03 10:58:01 +0000
+++ account/account_invoice.py	2012-04-27 12:35:21 +0000
@@ -1512,7 +1512,8 @@
                                                        partner_id=partner_id, fposition_id=fposition_id)
         unique_tax_ids = set(tax_ids)
         if product_change_result and 'value' in product_change_result and 'invoice_line_tax_id' in product_change_result['value']:
-            unique_tax_ids |= set(product_change_result['value']['invoice_line_tax_id'])
+            # Product tax overrides account tax
+            unique_tax_ids = product_change_result['value']['invoice_line_tax_id']
         return {'value':{'invoice_line_tax_id': list(unique_tax_ids)}}
 
 account_invoice_line()

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to