Review: Needs Fixing

FYI, the fix was applied in 6.1 at revision 6767. But I don't think it was a 
good idea to hardcode unicode('utf-8').
The safer way to accomplish this is to use tools.ustr() which will behave 
properly in case the parameter is already unicode. It could happen if someone 
else inherits fields_view_get and converts res['arch'] to unicode upstream, for 
instance. This is our standard technique to coerce anything to unicode.

Thanks!
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-944761-amp/+merge/100272
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-944761-amp.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to