Looks good to me code-wise, although I wonder if both updates couldn't be moved to the same condition? Like the second chunk (parent_context.update) be moved up to the context_get conditional? It does not seem to depend on anything done inbetween: the only key changed in `parent_context` is `'group_by'`, and `params` is only accessed for reading. -- https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-opw-51150-xal/+merge/104623 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/6.0-opw-51150-xal.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
