Review: Approve Looks good to me, as long as we keep in mind that this is not a solution to the underlying issue with module loading order, but a hack to bypass the issue in this particular case.
Some minor things that could be improved: - adding the @oldname attribute (e.g. oldname='optin') to the renamed field would help the ORM smoothly migrate existing columns without requiring an explicit migration step - when changing typos/case in translated terms, doing a quick search-and-replace of the term in the POT and PO files helps make sure we won't needlessly lose the existing translations Thanks! -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-995986-rco/+merge/105042 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-995986-rco. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
